Skip to content

🔥 remove more-info-updater#4544

Merged
balloob merged 2 commits into
home-assistant:devfrom
iantrich:remove-updater
Jan 22, 2020
Merged

🔥 remove more-info-updater#4544
balloob merged 2 commits into
home-assistant:devfrom
iantrich:remove-updater

Conversation

@iantrich
Copy link
Copy Markdown
Member

binary_sensor.updater uses the default more-info dialog. This looks to not be used or I'm missing something.

@iantrich iantrich requested a review from bramkragten January 21, 2020 04:14
@iantrich iantrich self-assigned this Jan 21, 2020
@bramkragten
Copy link
Copy Markdown
Member

Did this ever work? It looks at the domain but the domain is not updater but binary_sensor we could also fix this in state_more_info_type ?

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Jan 21, 2020

It used to work, when it was named updater.updater

@iantrich
Copy link
Copy Markdown
Member Author

Not sure if it is worth to "fix" this 🤷‍♂ really just adds a link instead of text for the link

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Jan 21, 2020

It used to work, when it was named updater.updater

Ah, the domain changed? That explains it... home-assistant/core#25418

@iantrich
Copy link
Copy Markdown
Member Author

So, remove it, right?

@balloob balloob merged commit 572215b into home-assistant:dev Jan 22, 2020
@iantrich iantrich deleted the remove-updater branch January 23, 2020 03:53
@lock lock Bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants