Updater component is always available and shows on/off depending on whether an update is available or not by Santobert · Pull Request #25418 · home-assistant/core

Santobert · 2019-07-23T08:44:15Z

Breaking Change:

The updater component is now a binary sensor that is always available. The entity ID is binary_sensor.updater. The state is on/off depending on whether an update is available or not. The latest version as well as the release notes are attributes of this binary sensor.

Automations that are listening for the existence of updater.updater should now trigger when binary_sensor.updater changes to on.

This makes the component more transparent and understandable for the user. Additionally it is visible if there is an error or the source (https://updater.home-assistant.io/) is outdated.

Description:

See Breaking Change.

Furthermore the updater logs a warning if the current version is before the newest version. This is the case if the JSON from https://updater.home-assistant.io/ is outdated.

If you don't want the updater component to always be available, I suggest at least keeping the warning if the current version is greater than the newest version. Otherwise, people would wonder if the updater component is broken.

But personally, I think it would be more understandable if the updater component is always visible and displays the newest version. Automations can be triggered by the state and not by the existence of this component.

Related issue (if applicable): fixes #24385

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9957

Example entry for `configuration.yaml` (if applicable):

No changes

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code does not interact with devices:

Tests have been added to verify that the new code works.

…te is available

homeassistant · 2019-07-23T08:44:17Z

Hi @Santobert,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

ghost · 2019-07-23T08:44:23Z

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (updater) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Santobert · 2019-07-23T09:10:07Z

Please give me feedback if this change is acceptable. If so, I will update the documentation as soon as possible.

frenck · 2019-07-23T10:53:34Z

Please don't hold off creating a documentation PR, it slows down all progress, since merging without docs is a no go to being with. Adding docs-missing label.

Santobert · 2019-07-23T11:38:15Z

The documentation now is up to date: home-assistant/home-assistant.io#9957

Santobert · 2019-07-28T15:27:44Z

The docs-missing label can be removed. I've added the docs here: home-assistant/home-assistant.io#9957

Santobert · 2019-07-31T06:43:07Z

I guess there is something wrong with the CI? These errors are import errors and they have nothing to do with my changes.

This reverts commit 3f896a4.

Santobert · 2019-08-02T10:19:35Z

The platform is already tested in the current tests. Make sure all the new state attributes are tested. The only method not tested is probably the remove method that is called when the entity is removed. I'm not sure when that would happen here, since there's no config entry.

@MartinHjelmare I'm afraid we have to test the remove method since we miss the coverage target by 0.12% 😆 Can we call that method directly or do we have to trigger hass to remove the component?

Santobert · 2019-08-06T12:02:02Z

Thank you @MartinHjelmare for all your help. I wouldn't have been able to do this without you.

Is it possible to merge this into the upcoming version 0.97.0 or do we have to wait for 0.97.1?

MartinHjelmare · 2019-08-06T12:27:24Z

I think we should wait until 0.98 since it's a new feature and a breaking change.

MartinHjelmare · 2019-08-06T12:29:20Z

Please update the breaking change paragraph in the PR description with what the user needs to do to cope with the breaking change. Ie how to handle the change of entity domain for the updater entity.

Santobert · 2019-08-06T12:38:05Z

Please update the breaking change paragraph in the PR description with what the user needs to do to cope with the breaking change. Ie how to handle the change of entity domain for the updater entity.

Done

MartinHjelmare · 2019-08-06T12:42:39Z

@balloob ok to merge?

Updater Component is always available and shows on/off wether an upda…

79efbaf

…te is available

Santobert requested a review from a team as a code owner July 23, 2019 08:44

homeassistant added the cla-needed label Jul 23, 2019

probot-home-assistant Bot added core has-tests integration: updater small-pr PRs with less than 30 lines. labels Jul 23, 2019

homeassistant added cla-signed and removed cla-needed labels Jul 23, 2019

Use == instead of is to compare strings

008b145

frenck added the docs-missing label Jul 23, 2019

Santobert mentioned this pull request Jul 23, 2019

Edit updater component to match PR #25418 home-assistant/home-assistant.io#9957

Merged

2 tasks

balloob reviewed Jul 25, 2019

View reviewed changes

Comment thread homeassistant/components/updater/__init__.py Outdated

frenck removed the docs-missing label Jul 28, 2019

MartinHjelmare reviewed Jul 31, 2019

View reviewed changes

Comment thread homeassistant/components/updater/__init__.py Outdated

Edit log message when local version is newer

9efcbb7

MartinHjelmare reviewed Jul 31, 2019

View reviewed changes

Comment thread homeassistant/components/updater/__init__.py Outdated

Santobert added 4 commits July 31, 2019 19:35

One more commit to trigger CI

c50a515

Merge branch 'dev' into edit_updater_component

842e49f

Add binary sensor

eaf3620

Remove ATTR

b31bffe

MartinHjelmare requested changes Aug 1, 2019

View reviewed changes

Comment thread homeassistant/components/updater/binary_sensor.py Outdated

Comment thread homeassistant/components/updater/binary_sensor.py Outdated

Comment thread homeassistant/components/updater/binary_sensor.py Outdated

Comment thread homeassistant/components/updater/binary_sensor.py Outdated

Use dispatcher

e1df96e

Santobert added 5 commits August 2, 2019 00:56

Fix tests

cc927da

Test release notes

6be42c8

Add one more test

92d2a4b

Add another test

3f896a4

Add docstring

82af5f3

MartinHjelmare reviewed Aug 2, 2019

View reviewed changes

Comment thread tests/components/updater/test_init.py Outdated

Santobert added 2 commits August 2, 2019 10:55

Revert "Add another test"

5e2bae5

This reverts commit 3f896a4.

Remove unused file

22976d2

MartinHjelmare reviewed Aug 2, 2019

View reviewed changes

Comment thread tests/components/updater/test_init.py Outdated

MartinHjelmare reviewed Aug 2, 2019

View reviewed changes

Comment thread tests/components/updater/test_init.py Outdated

Santobert added 2 commits August 2, 2019 11:33

Update docstrings

c63db00

mock time

42e3d65

Test renaming entity

fa1b618

MartinHjelmare reviewed Aug 6, 2019

View reviewed changes

Comment thread tests/components/updater/test_init.py

Add test_rename_entity

69e7c86

MartinHjelmare reviewed Aug 6, 2019

View reviewed changes

Comment thread tests/components/updater/test_init.py Outdated

Comment thread tests/components/updater/test_init.py Outdated

Comment thread tests/components/updater/test_init.py Outdated

Improve test_rename_entity

53bec5e

MartinHjelmare approved these changes Aug 6, 2019

View reviewed changes

Santobert changed the title ~~Updater is always available and shows on/off wether an update is available~~ Updater component is always available and shows on/off depending on whether an update is available or not Aug 7, 2019

balloob added the breaking-change label Aug 7, 2019

balloob merged commit c3455ef into home-assistant:dev Aug 7, 2019

Santobert deleted the edit_updater_component branch August 7, 2019 22:29

mbo18 mentioned this pull request Aug 8, 2019

Update example following #9957 home-assistant/home-assistant.io#10086

Merged

lock Bot locked and limited conversation to collaborators Aug 8, 2019

Uh oh!

Conversation

Santobert commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Jul 23, 2019

Uh oh!

ghost commented Jul 23, 2019

Uh oh!

Santobert commented Jul 23, 2019

Uh oh!

frenck commented Jul 23, 2019

Uh oh!

Santobert commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Santobert commented Jul 28, 2019

Uh oh!

Uh oh!

Uh oh!

Santobert commented Jul 31, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Santobert commented Aug 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Santobert commented Aug 6, 2019

Uh oh!

MartinHjelmare commented Aug 6, 2019

Uh oh!

MartinHjelmare commented Aug 6, 2019

Uh oh!

Santobert commented Aug 6, 2019

Uh oh!

MartinHjelmare commented Aug 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Santobert commented Jul 23, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

Santobert commented Jul 23, 2019 •

edited

Loading

Santobert commented Aug 2, 2019 •

edited

Loading