Skip to content

Fix jumping on iOS when toggle switch #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Nov 29, 2019
Merged

Fix jumping on iOS when toggle switch #4275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/panels/lovelace/views/hui-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ export class HUIView extends LitElement {
flex: 1 0 0;
max-width: 500px;
min-width: 0;
/* on iOS devices the column can become wider when toggling a switch */
Copy link
Copy Markdown
Member

@balloob balloob Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should fix this at the place where we render the switch ?

Copy link
Copy Markdown
Member

@balloob balloob Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can't hurt to do it here in HUI-view 🤷‍♂ We really don't want things to escape horizontally anyway.

overflow-x: hidden;
}

.column > * {
Expand Down