Fix jumping on iOS when toggle switch#4275
Merged
bramkragten merged 1 commit intodevfrom Nov 29, 2019
Merged
Conversation
balloob
reviewed
Nov 26, 2019
| flex: 1 0 0; | ||
| max-width: 500px; | ||
| min-width: 0; | ||
| /* on iOS devices the column can become wider when toggling a switch */ |
Member
There was a problem hiding this comment.
I wonder if we should fix this at the place where we render the switch ?
Member
There was a problem hiding this comment.
I guess it can't hurt to do it here in HUI-view 🤷♂ We really don't want things to escape horizontally anyway.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't find the source of the problem so can not fix it...
This dirty fix does solve it, but will again break the mouse over of a graph (#3971)
Fixes #4212
Fixes #4179