Skip to content

Improve customize.yaml non-inclusion warning message #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 3 commits into from
Oct 14, 2019
Merged

Improve customize.yaml non-inclusion warning message #3995

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edecf9d
Improve customize.yaml non-inclusion warning message
scop Oct 13, 2019
5f29b66
Further tweak the message
scop Oct 13, 2019
88567df
Prettier
scop Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/panels/config/customize/ha-form-customize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,14 @@ class HaFormCustomize extends PolymerElement {
if="[[computeShowWarning(localConfig, globalConfig)]]"
>
<div class="warning">
It seems that your configuration.yaml doesn't properly include
customize.yaml<br />
Changes made here won't affect your configuration.
It seems that your configuration.yaml doesn't properly
<a
href="https://www.home-assistant.io/docs/configuration/customizing-devices/#customization-using-the-ui"
target="_blank"
>include customize.yaml</a
>.<br />
Changes made here are written in it, but will not be applied after a
Copy link
Copy Markdown
Member

@bramkragten bramkragten Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the after a restart it is not necessary to do a restart when making changes through the UI. (and there is a service for reloading customize homeassistant.reload_core_config)

Copy link
Copy Markdown
Member Author

@scop scop Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing that will send the wrong message. Pretty much the whole point of this change is that changes are applied immediately. But I'll change that to "after a configuration reload".

Copy link
Copy Markdown
Member

@bramkragten bramkragten Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed the part about current run time, that would actually be a bug I think...

Copy link
Copy Markdown
Member Author

@scop scop Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as is, just the warning message needs a tweak.

configuration reload unless the include is in place.
</div>
</template>
<template is="dom-if" if="[[hasLocalAttributes]]">
Expand Down