Improve customize.yaml non-inclusion warning message#3995
Merged
Conversation
Link to relevant docs, note that changes won't be applied after a restart if the include isn't in place (changes _do_ actually affect the current runtime configuration and are persisted in customize.yaml).
bramkragten
reviewed
Oct 13, 2019
| Changes made here won't affect your configuration. | ||
| It seems that your configuration.yaml doesn't properly | ||
| <a href="https://www.home-assistant.io/docs/configuration/customizing-devices/#customization-using-the-ui" target="_blank">include customize.yaml</a>.<br /> | ||
| Changes made here are written in it, but will not be applied after a |
Member
There was a problem hiding this comment.
remove the after a restart it is not necessary to do a restart when making changes through the UI. (and there is a service for reloading customize homeassistant.reload_core_config)
Member
Author
There was a problem hiding this comment.
Removing that will send the wrong message. Pretty much the whole point of this change is that changes are applied immediately. But I'll change that to "after a configuration reload".
Member
There was a problem hiding this comment.
Sorry missed the part about current run time, that would actually be a bug I think...
Member
Author
There was a problem hiding this comment.
I think it's fine as is, just the warning message needs a tweak.
bramkragten
approved these changes
Oct 13, 2019
Member
bramkragten
left a comment
bramkragten
left a comment
There was a problem hiding this comment.
OK to merge when travis passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to relevant docs, note that changes won't be applied after a
restart if the include isn't in place (changes do actually affect the
current runtime configuration and are persisted in customize.yaml).