add tap/hold actions to entity rows#3837
Closed
iantrich wants to merge 2 commits into
Closed
Conversation
2 tasks
bramkragten
approved these changes
Oct 1, 2019
Member
bramkragten
left a comment
bramkragten
left a comment
There was a problem hiding this comment.
I'm ok with this, @balloob you had some doubts last time around I believe...
balloob
reviewed
Oct 1, 2019
iantrich
changed the title
iantrich
changed the title
bramkragten
reviewed
Oct 7, 2019
| !DOMAINS_HIDE_MORE_INFO.includes(computeDomain(entityConf.entity)) | ||
| ) { | ||
| element.classList.add("state-card-dialog"); | ||
| element.addEventListener("click", () => this._handleClick(entityConf)); |
Member
There was a problem hiding this comment.
We now changed the behaviour of all entity rows? You can no longer click on the row to get the more-info?
Member
Author
There was a problem hiding this comment.
moved actions to the badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #2786
With the introduction of the ability to cast our lovelace views, this is an even more viable change as currently dialogs are not possible and clicking on entity rows therefore does nothing. This change will allow users to set custom tap/hold actions for their entity rows
Docs: home-assistant/home-assistant.io#8705
Closes home-assistant/ui-schema#238