Skip to content

Add support for automation description#3723

Merged
balloob merged 4 commits into
home-assistant:devfrom
emontnemery:automation_annotation
Sep 20, 2019
Merged

Add support for automation description#3723
balloob merged 4 commits into
home-assistant:devfrom
emontnemery:automation_annotation

Conversation

@emontnemery
Copy link
Copy Markdown
Collaborator

@emontnemery emontnemery commented Sep 15, 2019

When using the automation editor, any manually added comments are wiped.
Allow adding description string to the automation instead, with the same purpose as a comment.

Depends on backend PR: home-assistant/core#26662

Screenshots:
image

image

@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Sep 15, 2019

I really love this idea. Both for this particular use case of remembering logic in your personal automations, but also for the future if we get automation sharing, this would be a great way to describe your shared automation to the community.

I'm just not sure that everyone will know what "Annotation" means? I know it's the correct word but I think that "Description", "Note", or "Comment" might be more easily understandable to a wider group of people IMO.

Also I think that the label and/or placeholder text should make clear that it's optional too.

@emontnemery
Copy link
Copy Markdown
Collaborator Author

emontnemery commented Sep 15, 2019

@SeanPM5 OK, have a look at the updated screenshots, maybe better now.
Do you think it should be mentioned in the placeholder that the comment can be multple lines?

Note: Code should also be changed from annotation to comment

@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 16, 2019

I like the idea, but let's call it description.

@emontnemery emontnemery changed the title Add support for automation annotation Add support for automation description Sep 17, 2019
@emontnemery
Copy link
Copy Markdown
Collaborator Author

@balloob Fixed!

Comment thread src/translations/en.json Outdated
@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 17, 2019

We might have to do one more frontend release for the final release. As this PR relies on backend code that is not in tomorrows release , we should not merge this yet.

@balloob balloob merged commit eee0c2e into home-assistant:dev Sep 20, 2019
@bramkragten bramkragten mentioned this pull request Oct 2, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants