Skip to content

Add support for automation description#26662

Merged
balloob merged 2 commits into
home-assistant:devfrom
emontnemery:automation_annotation
Sep 17, 2019
Merged

Add support for automation description#26662
balloob merged 2 commits into
home-assistant:devfrom
emontnemery:automation_annotation

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Sep 15, 2019

Description:

When using the automation editor, any manually added comments are wiped.
Allow adding a description string to the automation instead, with the same purpose as a comment.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emontnemery
Copy link
Copy Markdown
Contributor Author

Are tests needed for this?

@MartinHjelmare
Copy link
Copy Markdown
Member

Probably, but wait for a core review if this feature hasn't already been discussed.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Sep 15, 2019

I mean there is an proposal on architecture repository. I would suggest to implement this proposal.

@emontnemery
Copy link
Copy Markdown
Contributor Author

@pvizeli I can't find it, can you share the issue number?

Comment thread homeassistant/components/automation/__init__.py Outdated
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Sep 16, 2019

@emontnemery emontnemery changed the title Add support for automation annotation Add support for automation description Sep 17, 2019
@balloob balloob merged commit 10572a6 into home-assistant:dev Sep 17, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 18, 2019
@emontnemery emontnemery deleted the automation_annotation branch October 3, 2019 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants