Display history charts up to end of selected time#254
Merged
Conversation
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrey-git, @balloob and @justweb1 to be potential reviewers. |
Contributor
|
Looks like a fix for home-assistant/core#6508 which I opened some time ago? Graphs used to work this way. |
Contributor
Author
|
Yes, it should fix that issue. I'm not sure where the bug was introduced though, or if an alternate implementation is preferred. |
Member
|
Looks good! 🐬 |
andrey-git
added a commit
to andrey-git/home-assistant-polymer
that referenced
this pull request
Apr 4, 2017
* Allow empty state name. (home-assistant#247) * Allow badge size control via variables. (home-assistant#246) * Allow using icon/name for default_view. Add hover-title whn using an icon. (home-assistant#244) * Don't propagate event from cover controls. (home-assistant#248) * Fix Safari maps issue * added missing executor (home-assistant#250) Executing a JS script fails on some systems (good thing I replaced my default program for JS on windows!). It's bad practice. * upgrade paper-slider and remove min-max hack (home-assistant#252) * Treat default_view as special only with view:true (home-assistant#251) * Add web-component-tester tests (home-assistant#255) * Use travis.yml from polymer * Update .travis.yml * Try wct tests * Encrypt Sauce env * More test config * Update2 * try to remove souce_connect * Try another config * More browsers * Clean tabs, test shadow dom. * Display history charts up to end of selected time (home-assistant#254) * Display history charts up to end time * Back into JS world
Merged
tkdrob
pushed a commit
to tkdrob/frontend
that referenced
this pull request
Apr 20, 2021
…istant#254) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the rendering of history charts to extend all the way to the requested end time. (See example below for illustration.) These screenshots were both taken at approx 16:50. Note from the scales at the bottom that the new scale extends all the way to the current time. This becomes very important for some entities that don't change state very frequently, since the new state might only occupy a sliver of the chart even if it has been in that state for a substantial amount of time.
Also, in order to accommodate this, I had to do some refactoring of ha-state-history-data. We were previously passing in a
filterValue, which was a query string that got passed directly to/history/period/. I refactored this so that we're instead passing the values natively, and generate the string only once we need to.Fixes home-assistant/core#6508
Old:
New:
