Skip to content

added missing executor#250

Merged
balloob merged 1 commit into
home-assistant:masterfrom
bdurrer:patch-1
Mar 31, 2017
Merged

added missing executor#250
balloob merged 1 commit into
home-assistant:masterfrom
bdurrer:patch-1

Conversation

@bdurrer
Copy link
Copy Markdown
Contributor

@bdurrer bdurrer commented Mar 31, 2017

Executing a JS script fails on some systems (good thing I replaced my default program for JS on windows!). It's bad practice.

Executing a JS script fails on some systems (good thing I replaced my default program for JS on windows!). It's bad practice.
@mention-bot
Copy link
Copy Markdown

@bdurrer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @armills and @syphernl to be potential reviewers.

@balloob balloob merged commit 7f69540 into home-assistant:master Mar 31, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 31, 2017

Thanks! I wonder what else is broken on Windows 😉

@bdurrer
Copy link
Copy Markdown
Contributor Author

bdurrer commented Mar 31, 2017

I'll find out :)
But I kinda gave up already, have a virtual box running :)

andrey-git added a commit to andrey-git/home-assistant-polymer that referenced this pull request Apr 4, 2017
* Allow empty state name. (home-assistant#247)

* Allow badge size control via variables. (home-assistant#246)

* Allow using icon/name for default_view. Add hover-title whn using an icon. (home-assistant#244)

* Don't propagate event from cover controls. (home-assistant#248)

* Fix Safari maps issue

* added missing executor (home-assistant#250)

Executing a JS script fails on some systems (good thing I replaced my default program for JS on windows!). It's bad practice.

* upgrade paper-slider and remove min-max hack (home-assistant#252)

* Treat default_view as special only with view:true (home-assistant#251)

* Add web-component-tester tests (home-assistant#255)

* Use travis.yml from polymer

* Update .travis.yml

* Try wct tests

* Encrypt Sauce env

* More test config

* Update2

* try to remove souce_connect

* Try another config

* More browsers

* Clean tabs, test shadow dom.

* Display history charts up to end of selected time (home-assistant#254)

* Display history charts up to end time

* Back into JS world
tkdrob pushed a commit to tkdrob/frontend that referenced this pull request Apr 20, 2021
Remove `plugin` line from site config which is not needed and in fact causes build to fail
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants