Skip to content

Update Lovelace Thermostat Card to include all supported thermostat m…#2039

Merged
zsarnett merged 8 commits intohome-assistant:devfrom
callifo:dev
Nov 14, 2018
Merged

Update Lovelace Thermostat Card to include all supported thermostat m…#2039
zsarnett merged 8 commits intohome-assistant:devfrom
callifo:dev

Conversation

@callifo
Copy link
Copy Markdown
Contributor

@callifo callifo commented Nov 11, 2018

Add support to Thermostat Card to include other thermostat operation modes,

on
fan_only
eco
dry
idle
electric
performance
high_demand
heat_pump
gas

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @callifo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@zsarnett
Copy link
Copy Markdown
Contributor

How do these icons look when on the thermostat? Have you tested all of them?

@iantrich
Copy link
Copy Markdown
Member

I haven't went through this code, but would think this would look bad if a thermostat supported all of these modes

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 11, 2018

We should only support buttons for official operation modes. This list is not it.

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 11, 2018

Also include a screenshot how this would look.

@zsarnett
Copy link
Copy Markdown
Contributor

STATE_HEAT = 'heat'
STATE_COOL = 'cool'
STATE_IDLE = 'idle'
STATE_AUTO = 'auto'
STATE_MANUAL = 'manual'
STATE_DRY = 'dry'
STATE_FAN_ONLY = 'fan_only'
STATE_ECO = 'eco'

List of Official Modes

@zsarnett
Copy link
Copy Markdown
Contributor

We will need screenshots on how each looks. If your thermostat only uses a certain amount of those and you can only test them . The PR should only be for those modes

@callifo
Copy link
Copy Markdown
Contributor Author

callifo commented Nov 11, 2018

I'll change it to those and get back to you. I took the list above from the Entity definition so assumed that was the official list.

'Manual' will require an update to the file where its localizing the string value as its not in there.

I have tested what mine supports, dry and fan (plus cool/heat), and I can probably use a demo thermostat to mock the rest of them up. I can't see a case where all of these would ever be supported on one card, so the number of elements and width wont be an issue.

@callifo
Copy link
Copy Markdown
Contributor Author

callifo commented Nov 12, 2018

Here are the mockups. Open to suggestions for colours... the manual, dry and idle would have no strip colour as they dont allow temperature control?

Modes: Off, Auto, Manual, Eco
off-auto-manual-eco-off
off-auto-manual-eco-auto_on
off-auto-manual-eco-manual_on
off-auto-manual-eco-eco_on

Modes: Off, Heat, Cool, Fan, Dry
off-heat-cool-fan-dry-off
off-heat-cool-fan-dry-fan_on
off-heat-cool-fan-dry-dry_on

@zsarnett
Copy link
Copy Markdown
Contributor

Remove Manual from the PR and I think it will be good to go. We currently have a PR for the Manual Mode addition

@callifo
Copy link
Copy Markdown
Contributor Author

callifo commented Nov 13, 2018

Ok sweet, will do tonight

@callifo
Copy link
Copy Markdown
Contributor Author

callifo commented Nov 13, 2018

Manual removed, to be completed in PR #2036

@zsarnett
Copy link
Copy Markdown
Contributor

I think that dry does need a color because it will be able to set a temperature. Its just like Cool but reduces the Humidity as well. Maybe Like #efbd07 Yellow or something. Really up to you as long as its not totally random haha

Copy link
Copy Markdown
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Color for dry is added. Good to Merge

@callifo
Copy link
Copy Markdown
Contributor Author

callifo commented Nov 14, 2018

Done, updated to #efbd07

@zsarnett
Copy link
Copy Markdown
Contributor

Looks Good! 👍

@zsarnett zsarnett merged commit adb39fd into home-assistant:dev Nov 14, 2018
@ghost ghost removed the in progress label Nov 14, 2018
@jncanches
Copy link
Copy Markdown

This is a great evolution, but for HVAC (MQTT HVAC for example), eco mode cannot be used because it behaves more like an addition to the mode than a full mode itself. It's a full mode for a simple air conditionner that can only make frost. But for a reversible (frost and heat) system, eco means heat less when i'm on heat mode and frost less when i'm in cold mode.
Do you see what I mean ?
With my MQTT HVAC, I must have a switch below my card to display the eco functionnality. It would be great to have a thermostat card that can turn this "eco mode" into an "eco switch" that can be turned on and off without deselecting the heat or cold mode.
Could be displayed on a second line of icon...

However, great work, as usual !

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants