Skip to content

Add icon for manual mode#2036

Merged
zsarnett merged 3 commits intohome-assistant:devfrom
TomMini:thermostat-icon
Nov 14, 2018
Merged

Add icon for manual mode#2036
zsarnett merged 3 commits intohome-assistant:devfrom
TomMini:thermostat-icon

Conversation

@TomMini
Copy link
Copy Markdown
Contributor

@TomMini TomMini commented Nov 10, 2018

Added an icon for manual operation mode to the lovelace thermostat card.

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 10, 2018

How does the icon look? And how does that look together with the other ones?

@TomMini
Copy link
Copy Markdown
Contributor Author

TomMini commented Nov 11, 2018

It's the hand cursor cursor-pointer, used for thermostats that support a manual-mode. If a thermostat has this operation in it's operationlist currently it's not rendered/controllable in the lovelace-ui at all.

@zsarnett
Copy link
Copy Markdown
Contributor

Can we get screen shots of the whole thermostat with manual mode being apart of it? Also, you will need to add Manual to the translations.

@TomMini
Copy link
Copy Markdown
Contributor Author

TomMini commented Nov 13, 2018

Here's the screen shot with manual mode enabled. Also made the color blue when in manual operation
image

@zsarnett zsarnett merged commit 8a9762d into home-assistant:dev Nov 14, 2018
@ghost ghost removed the in progress label Nov 14, 2018
@TomMini TomMini deleted the thermostat-icon branch November 14, 2018 07:29
zsarnett pushed a commit that referenced this pull request Nov 14, 2018
#2039)

* Update Lovelace Thermostat Card to include all supported thermostat modes

* Update hui-thermostat-card.ts

* Update en.json to include

* Update en.json

* Revert "Update en.json"

This reverts commit a71ed49.

* Revert "Update en.json to include"

This reverts commit 68b95ca.

* Removed manual mode, covered in PR #2036

* Update dry colour to #efbd07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants