Skip to content

Fix for thermostats without current temperature #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 4 commits into from
Nov 6, 2018
Merged

Fix for thermostats without current temperature #1979

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c148da
fix for thermostats without current temperature
Nov 4, 2018
2b99539
make linter happy
Nov 4, 2018
9db7c52
always render value, uom only when there is a value
Nov 5, 2018
8e79071
Update hui-thermostat-card.ts
balloob Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/panels/lovelace/cards/hui-thermostat-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,18 @@ export class HuiThermostatCard extends hassLocalizeLitMixin(LitElement)
<div id="tooltip">
<div class="title">${computeStateName(stateObj)}</div>
<div class="current-temperature">
Comment thread
schmic marked this conversation as resolved.
<span class="current-temperature-text">${
stateObj.attributes.current_temperature
}
<span class="uom">${
this.hass.config.unit_system.temperature
}</span>
</span>
${
stateObj.attributes.current_temperature
? html`
<span class="current-temperature-text">

@zsarnett zsarnett Nov 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out the surrounding Span of current-temperature-text and only have

${stateObj.attributes.current_temperature}
<span class="uom">
   ${this.hass.config.unit_system.temperature}
</span>

This be the rendered or not rendered part. and then in the else just html``

${stateObj.attributes.current_temperature}
<span class="uom">
${this.hass.config.unit_system.temperature}
</span>
</span>
`
: html`<span class="current-temperature-text"></span>`
}
</div>
<div class="climate-info">
<div id="set-temperature"></div>
Expand Down