Fix for thermostats without current temperature#1979
Merged
balloob merged 4 commits intohome-assistant:devfrom Nov 6, 2018
schmic:fix-thermostat-card
Merged
Fix for thermostats without current temperature#1979balloob merged 4 commits intohome-assistant:devfrom schmic:fix-thermostat-card
balloob merged 4 commits intohome-assistant:devfrom
schmic:fix-thermostat-card
Conversation
ghost
added
the
Contributor
Author
|
Thermostats like the Z-Wave based Danfoss 014G0013 don't have current_temperature, operation_mode and operation_list ... |
zsarnett
reviewed
Nov 4, 2018
zsarnett
reviewed
Nov 4, 2018
zsarnett
reviewed
Nov 5, 2018
| ${ | ||
| stateObj.attributes.current_temperature | ||
| ? html` | ||
| <span class="current-temperature-text"> |
Contributor
There was a problem hiding this comment.
Take out the surrounding Span of current-temperature-text and only have
${stateObj.attributes.current_temperature}
<span class="uom">
${this.hass.config.unit_system.temperature}
</span>
This be the rendered or not rendered part. and then in the else just html``
balloob
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.