Skip to content

Add option for multiple models and manufacturers#15104

Closed
exciton wants to merge 3 commits into
home-assistant:devfrom
exciton:multiple_deviced_selector_models
Closed

Add option for multiple models and manufacturers#15104
exciton wants to merge 3 commits into
home-assistant:devfrom
exciton:multiple_deviced_selector_models

Conversation

@exciton
Copy link
Copy Markdown

@exciton exciton commented Jan 13, 2023

Breaking change

Proposed change

This change (coupled with a corresponding one in core - home-assistant/core#85852 ) enables multiple manufacturers or models to be specified in device selectors. This is useful in blueprints where there are multiple identically-behaving models that have different names - the change enables these to share a blueprint and avoids a lot of duplication.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

selector:
  device:
    model:
      - Model X
      - Model Y

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the changes 👍 Don't forget to edit the documentation if the core PR is accepted.
https://www.home-assistant.io/docs/blueprint/selectors/#device-selector

Comment thread src/data/selector.ts Outdated
Comment thread src/data/selector.ts Outdated
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Apr 18, 2023
@github-actions github-actions Bot closed this Apr 25, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants