Add option for multiple models and manufacturers#15104
Closed
exciton wants to merge 3 commits into
Closed
Conversation
piitaya
approved these changes
Jan 16, 2023
Member
piitaya
left a comment
There was a problem hiding this comment.
I'm ok with the changes 👍 Don't forget to edit the documentation if the core PR is accepted.
https://www.home-assistant.io/docs/blueprint/selectors/#device-selector
frenck
reviewed
Jan 16, 2023
piitaya
requested changes
Jan 16, 2023
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
9 tasks
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This change (coupled with a corresponding one in core - home-assistant/core#85852 ) enables multiple manufacturers or models to be specified in device selectors. This is useful in blueprints where there are multiple identically-behaving models that have different names - the change enables these to share a blueprint and avoids a lot of duplication.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: