Add option for multiple models and manufacturers#85852
Closed
exciton wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi exciton It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
9 tasks
davidn
approved these changes
Apr 6, 2023
davidn
left a comment
There was a problem hiding this comment.
Successfully tested with a very simple blueprint:
blueprint:
name: PR 85852 test blueprint
description: test for PR85852
domain: automation
input:
device_input:
selector:
device:
model:
- "LUH-A602S-WUS"
- nonsuch
trigger:
- platform: time
at: "11:42:00"
action:
- service: notify.notify
data:
message: !input device_input
Member
|
This feature has been implemented in the latest release. https://www.home-assistant.io/blog/2023/04/05/release-20234/#new-selector-capabilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This change (coupled with a corresponding one in frontend) enables multiple manufacturers or models to be specified in device selectors. This is useful in blueprints where there are multiple identically-behaving models that have different names - the change enables these to share a blueprint and avoids a lot of duplication.
e.g.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: