Skip to content

Add option for multiple models and manufacturers#85852

Closed
exciton wants to merge 1 commit into
home-assistant:devfrom
exciton:multiple_device_selector_models
Closed

Add option for multiple models and manufacturers#85852
exciton wants to merge 1 commit into
home-assistant:devfrom
exciton:multiple_device_selector_models

Conversation

@exciton
Copy link
Copy Markdown
Contributor

@exciton exciton commented Jan 13, 2023

Breaking change

Proposed change

This change (coupled with a corresponding one in frontend) enables multiple manufacturers or models to be specified in device selectors. This is useful in blueprints where there are multiple identically-behaving models that have different names - the change enables these to share a blueprint and avoids a lot of duplication.

e.g.

selector:
  device:
    model:
      - Model X
      - Model Y

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hi exciton

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown

@davidn davidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with a very simple blueprint:

blueprint:
name: PR 85852 test blueprint
description: test for PR85852
domain: automation
input:
device_input:
selector:
device:
model:
- "LUH-A602S-WUS"
- nonsuch

trigger:
  - platform: time
    at: "11:42:00"

action:
  - service: notify.notify
    data:
      message: !input device_input

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 6, 2023

This feature has been implemented in the latest release. https://www.home-assistant.io/blog/2023/04/05/release-20234/#new-selector-capabilities

@balloob balloob closed this Apr 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants