Accept new value when hitting ENTER to close a prompt dialog

[Stormalong]

…essed

Proposed change

This fixes a bug that causes hitting ENTER to close a prompt dialog to not accept the new value.

Steps to reproduce:

• go to Configuration
• go to Devices & Services
• click the kebab menu on any card and select Rename
• type in a new name and hit ENTER (do not click OK)
• the dialog will close but the name will not be changed

The existing code clearly intends for hitting ENTER (keycode 13) to accept the new value (by calling _confirm) but it doesn't work because the @change event isn't called for keystrokes.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[zsarnett]

This will now call the value changed event each time a key is pressed..

Meant to just comment

[steverep]

I noticed this issue as well. Someone else reported in #12206. Per my comments, a better fix should be just to get rid of the key up and value changed handler methods, and grab the current field value in the confirm method, saving a bunch of lines of code.

[steverep]

This handler is doing nothing because mwc-dialog hits the primary confirm button on enter key down, not up. The bug occurs because the confirm method then gets called before this._value is updated (because the change event only fires when focus is removed).

[steverep]

This is not a good fix because it's just unnecessarily updating the state variable every time an input character is changed, and probably causing the lit element to keep rescheduling render updates.