Skip to content

Accept new value when hitting ENTER to close a prompt dialog #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsarnett merged 4 commits into from
Apr 22, 2022
Merged

Accept new value when hitting ENTER to close a prompt dialog #12360

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d5f4fe
fix for prompt dialog not taking the new value if the ENTER key is pr…
Stormalong Apr 20, 2022
7487869
Update src/dialogs/generic/dialog-box.ts
Stormalong Apr 22, 2022
bb54d7b
Update src/dialogs/generic/dialog-box.ts
Stormalong Apr 22, 2022
88a1c0d
Update src/dialogs/generic/dialog-box.ts
Stormalong Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dialogs/generic/dialog-box.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class DialogBox extends LitElement {
dialogInitialFocus
.value=${this._value || ""}
@keyup=${this._handleKeyUp}
Copy link
Copy Markdown
Member

@steverep steverep Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handler is doing nothing because mwc-dialog hits the primary confirm button on enter key down, not up. The bug occurs because the confirm method then gets called before this._value is updated (because the change event only fires when focus is removed).

@change=${this._valueChanged}
@input=${this._valueChanged}
Copy link
Copy Markdown
Member

@steverep steverep Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good fix because it's just unnecessarily updating the state variable every time an input character is changed, and probably causing the lit element to keep rescheduling render updates.

.label=${this._params.inputLabel
? this._params.inputLabel
: ""}
Expand Down