Skip to content

Add YoLink product integration#69167

Merged
MartinHjelmare merged 21 commits intohome-assistant:devfrom
YoSmart-Inc:yolink-0.0.1
May 17, 2022
Merged

Add YoLink product integration#69167
MartinHjelmare merged 21 commits intohome-assistant:devfrom
YoSmart-Inc:yolink-0.0.1

Conversation

@matrixd2
Copy link
Copy Markdown
Contributor

@matrixd2 matrixd2 commented Apr 3, 2022

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here some quick comments to get you started. It would be great if you could remove all non relevant code for this PR, since this will help to speed up the review and also to have a better overview of your contribution.

@matrixd2
Copy link
Copy Markdown
Contributor Author

Here some quick comments to get you started. It would be great if you could remove all non relevant code for this PR, since this will help to speed up the review and also to have a better overview of your contribution.

I have solved the above problem. Please review again

@mclever
Copy link
Copy Markdown

mclever commented Apr 19, 2022

What's next @iMicknl ?

@matrixd2
Copy link
Copy Markdown
Contributor Author

@iMicknl Is there anything else to deal with

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I didn't look at the tests yet.

@matrixd2 matrixd2 requested a review from MartinHjelmare May 3, 2022 02:04
@matrixd2 matrixd2 requested a review from MartinHjelmare May 4, 2022 00:51
@matrixd2 matrixd2 requested a review from MartinHjelmare May 4, 2022 16:52
@matrixd2 matrixd2 requested a review from MartinHjelmare May 5, 2022 09:41
@matrixd2 matrixd2 requested a review from MartinHjelmare May 5, 2022 11:35
@matrixd2 matrixd2 requested a review from MartinHjelmare May 5, 2022 16:03
@matrixd2 matrixd2 requested a review from MartinHjelmare May 6, 2022 11:38
@matrixd2
Copy link
Copy Markdown
Contributor Author

matrixd2 commented May 7, 2022

what's next? @MartinHjelmare

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please link a docs PR in this PR description.

Are you planning to request a Home Assistant Cloud Account Linking service?

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#configuration-via-oauth2

@matrixd2 matrixd2 requested a review from MartinHjelmare May 10, 2022 11:10
@matrixd2 matrixd2 requested a review from MartinHjelmare May 10, 2022 15:08
@MartinHjelmare
Copy link
Copy Markdown
Member

Just waiting for a frontend release now so we can use application credentials.

@matrixd2 matrixd2 requested a review from MartinHjelmare May 13, 2022 11:34
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit e0154d6 into home-assistant:dev May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants