Add YoLink product integration#69167
Add YoLink product integration#69167MartinHjelmare merged 21 commits intohome-assistant:devfrom YoSmart-Inc:yolink-0.0.1
Conversation
iMicknl
left a comment
There was a problem hiding this comment.
Here some quick comments to get you started. It would be great if you could remove all non relevant code for this PR, since this will help to speed up the review and also to have a better overview of your contribution.
I have solved the above problem. Please review again |
|
What's next @iMicknl ? |
|
@iMicknl Is there anything else to deal with |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I didn't look at the tests yet.
|
what's next? @MartinHjelmare |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good!
Please link a docs PR in this PR description.
Are you planning to request a Home Assistant Cloud Account Linking service?
|
Just waiting for a frontend release now so we can use application credentials. |
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: