Skip to content

Add shade to device class overrides#11874

Merged
zsarnett merged 1 commit intohome-assistant:devfrom
jpearl:shade_deviceclass
Mar 14, 2022
Merged

Add shade to device class overrides#11874
zsarnett merged 1 commit intohome-assistant:devfrom
jpearl:shade_deviceclass

Conversation

@jpearl
Copy link
Copy Markdown
Contributor

@jpearl jpearl commented Feb 27, 2022

Proposed change

Adds support for shade device class override for cover

Note: while this change conforms to the current model of entity type overrides, this PR request is still likely desired/warranted to add full support for all device classes in Cover Groups so that future device classes don't need to be individually added here.

(cc @KNXBroker)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • [ X ] New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • [ X ] The code change is tested and works locally.
  • [ X ] There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @jpearl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@KNXBroker
Copy link
Copy Markdown

Thank you @jpearl

@jpearl
Copy link
Copy Markdown
Contributor Author

jpearl commented Mar 11, 2022

Pinging. Am I missing a step to get this reviewed? TIA

@zsarnett zsarnett merged commit 84ffa23 into home-assistant:dev Mar 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants