Skip to content

Add cover group device class support#60415

Closed
KNXBroker wants to merge 1 commit intohome-assistant:devfrom
KNXBroker:cover-group-device-class
Closed

Add cover group device class support#60415
KNXBroker wants to merge 1 commit intohome-assistant:devfrom
KNXBroker:cover-group-device-class

Conversation

@KNXBroker
Copy link
Copy Markdown
Contributor

@KNXBroker KNXBroker commented Nov 26, 2021

Proposed change

Adding device class support for cover groups. Up to now this had only be possible via customizing, which is no longer promoted.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@KNXBroker KNXBroker marked this pull request as ready for review November 26, 2021 20:23
@KNXBroker KNXBroker requested a review from a team as a code owner November 26, 2021 20:23
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 29, 2021

Up to now this had only be possible via customizing, which is no longer promoted.

I'm not sure what this means? We never promoted customize?

Anyways, there is currently being worked towards adding the possibility to select the device class on an entity, which makes this PR obsolete?

@KNXBroker
Copy link
Copy Markdown
Contributor Author

My driver was to reduce customization entries, as I saw that the customization GUI will be removed. Anyways I never liked defining things via customization / defining things at different places (cover group definition via yaml and device class definition via customization).

I'm not aware about the new way of assigning device classes. If this is something which can be done via the GUI and if groups can be defined in future via GUI as well, I fully agree.

Please advice if I shall close this PR.

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 29, 2021

I'm not aware about the new way of assigning device classes

This is currently being developed and is similar to how you can set an icon, name, or area on an entity via the UI.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 29, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 29, 2021

Closing this PR, as this functionality is now available from the UI

@frenck frenck closed this Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants