Skip to content

Fix WebRTC player stream playback when disconnected/connected #11764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Feb 21, 2022
Merged

Fix WebRTC player stream playback when disconnected/connected #11764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/ha-web-rtc-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class HaWebRtcPlayer extends LitElement {

private _remoteStream?: MediaStream;

protected render(): TemplateResult {
protected override render(): TemplateResult {
if (this._error) {
return html`<ha-alert alert-type="error">${this._error}</ha-alert>`;
}
Expand All @@ -58,12 +58,19 @@ class HaWebRtcPlayer extends LitElement {
`;
}

public disconnectedCallback() {
public override connectedCallback() {
super.connectedCallback();
if (this.hasUpdated) {
this._startWebRtc();
}
}

public override disconnectedCallback() {
super.disconnectedCallback();
this._cleanUp();
}

protected updated(changedProperties: PropertyValues<this>) {
protected override updated(changedProperties: PropertyValues<this>) {
if (!changedProperties.has("entityid")) {
return;
}
Expand Down