Skip to content

Fix WebRTC player stream playback when disconnected/connected#11764

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
allenporter:stream-cleanup
Feb 21, 2022
Merged

Fix WebRTC player stream playback when disconnected/connected#11764
bramkragten merged 1 commit intohome-assistant:devfrom
allenporter:stream-cleanup

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Fix a bug in WebRTC player where the stream would not play when changing tabs. Add a connectedCallback to restart the
stream when the element is reconnected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Fix a bug in WebRTC player where the stream would not play when changing tabs. Add a connectedCallback to restart the
stream when the element is reconnected.
@bramkragten bramkragten enabled auto-merge (squash) February 21, 2022 20:33
@bramkragten bramkragten merged commit eb1f94c into home-assistant:dev Feb 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebRTC camera entities do not display when navigating away from the page and returning

3 participants