Skip to content

Script Editor to Ha Form#11601

Merged
zsarnett merged 11 commits intodevfrom
script-sequence-editor-action-to-ha-form
Feb 14, 2022
Merged

Script Editor to Ha Form#11601
zsarnett merged 11 commits intodevfrom
script-sequence-editor-action-to-ha-form

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Feb 8, 2022

Breaking change

Proposed change

change Over Sequence editor in scripts to ha-form

[ ] change first form to ha form

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett marked this pull request as draft February 8, 2022 03:37
@zsarnett zsarnett changed the title Script Sequence Editor to Ha Form Script Editor to Ha Form Feb 8, 2022
@zsarnett zsarnett marked this pull request as ready for review February 8, 2022 21:07
Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out why the schema for the mode and entity id are being continuously added everytime render happens...

image

Comment on lines +36 to +37
const value = typeof item === "object" ? item.value : item;
const label = typeof item === "object" ? item.label : item;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the object better, but not sure how well it translates to the backend

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can switch it but I also like object better... the other is very ambiguous it seems

@zsarnett zsarnett force-pushed the script-sequence-editor-action-to-ha-form branch from 0973de6 to 591d55d Compare February 11, 2022 01:09
@zsarnett zsarnett added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Feb 11, 2022
@zsarnett zsarnett force-pushed the script-sequence-editor-action-to-ha-form branch from cafec15 to fd077fe Compare February 14, 2022 17:09
zsarnett and others added 3 commits February 14, 2022 11:13
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@zsarnett zsarnett merged commit 460b900 into dev Feb 14, 2022
@zsarnett zsarnett deleted the script-sequence-editor-action-to-ha-form branch February 14, 2022 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants