Merged
Conversation
bramkragten
reviewed
Feb 9, 2022
bramkragten
reviewed
Feb 9, 2022
bramkragten
reviewed
Feb 9, 2022
Comment on lines
+36
to
+37
| const value = typeof item === "object" ? item.value : item; | ||
| const label = typeof item === "object" ? item.label : item; |
Member
There was a problem hiding this comment.
Or should we do it like ha-form? 🤔
Member
There was a problem hiding this comment.
I like the object better, but not sure how well it translates to the backend
Contributor
Author
There was a problem hiding this comment.
I can switch it but I also like object better... the other is very ambiguous it seems
bramkragten
reviewed
Feb 9, 2022
bramkragten
reviewed
Feb 9, 2022
bramkragten
reviewed
Feb 9, 2022
0973de6 to
591d55d
Compare
balloob
reviewed
Feb 11, 2022
balloob
reviewed
Feb 11, 2022
balloob
reviewed
Feb 11, 2022
balloob
reviewed
Feb 11, 2022
9 tasks
cafec15 to
fd077fe
Compare
bramkragten
reviewed
Feb 14, 2022
bramkragten
reviewed
Feb 14, 2022
bramkragten
reviewed
Feb 14, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
change Over Sequence editor in scripts to ha-form
[ ] change first form to ha form
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: