Skip to content

Another round of paper-dropdown -> mwc-select conversion#11674

Merged
bramkragten merged 6 commits intodevfrom
another-round-of-dropbox
Feb 14, 2022
Merged

Another round of paper-dropdown -> mwc-select conversion#11674
bramkragten merged 6 commits intodevfrom
another-round-of-dropbox

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett self-requested a review February 14, 2022 04:55
@zsarnett zsarnett self-assigned this Feb 14, 2022
balloob
balloob previously approved these changes Feb 14, 2022
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of missing imports. Rest looks good!

@bramkragten bramkragten force-pushed the another-round-of-dropbox branch from 6b86ebb to 990fdab Compare February 14, 2022 19:01
@bramkragten bramkragten merged commit 523afe2 into dev Feb 14, 2022
@bramkragten bramkragten deleted the another-round-of-dropbox branch February 14, 2022 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants