Skip to content

Display transmitted messages in MQTT debug info dialog #11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 3 commits into from
Feb 15, 2022
Merged

Display transmitted messages in MQTT debug info dialog #11531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4df8ac7
Display transmitted messages in MQTT debug info dialog
emontnemery Feb 3, 2022
b59f7e4
Fix lint errors
emontnemery Feb 3, 2022
b1231f0
Address review comments
emontnemery Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/data/mqtt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export interface MQTTEntityDebugInfo {
entity_id: string;
discovery_data: MQTTDiscoveryDebugInfo;
subscriptions: MQTTTopicDebugInfo[];
transmitted: MQTTTopicDebugInfo[];
}

export interface MQTTTriggerDebugInfo {
Expand Down
27 changes: 26 additions & 1 deletion ...s/config/devices/device-detail/integration-elements/mqtt/dialog-mqtt-device-debug-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ class DialogMQTTDeviceDebugInfo extends LitElement {
<code>${topic.topic}</code>
<mqtt-messages
.hass=${this.hass}
direction="Received"
.messages=${topic.messages}
.showDeserialized=${this._showDeserialized}
.showAsYaml=${this._showAsYaml}
Expand All @@ -174,7 +175,31 @@ class DialogMQTTDeviceDebugInfo extends LitElement {
topic.messages.length
)}
>
</mqtt-messages>
</mqtt-rx-messages>
</li>
`
)}
</ul>
Transmitted messages:
<ul>
${entity.transmitted.map(
(topic) => html`
<li>
<code>${topic.topic}</code>
<mqtt-messages
.hass=${this.hass}
direction="Transmitted"
.messages=${topic.messages}
.showDeserialized=${this._showDeserialized}
.showAsYaml=${this._showAsYaml}
.subscribedTopic=${topic.topic}
.summary=${this.hass!.localize(
"ui.dialogs.mqtt_device_debug_info.recent_tx_messages",
"n",
topic.messages.length
)}
>
</mqtt-tx-messages>
</li>
`
)}
Expand Down
4 changes: 3 additions & 1 deletion src/panels/config/devices/device-detail/integration-elements/mqtt/mqtt-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ class MQTTMessages extends LitElement {

@property() public messages!: MQTTMessage[];

@property() public direction!: string;

@property() public showAsYaml = false;

@property() public showDeserialized = false;
Expand Down Expand Up @@ -50,7 +52,7 @@ class MQTTMessages extends LitElement {
(message) => html`
<li class="message">
<div class="time">
Received
${this.direction}
Copy link
Copy Markdown
Member

@bramkragten bramkragten Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have kept it 1 element and add a direction property to it 😄

Copy link
Copy Markdown
Collaborator Author

@emontnemery emontnemery Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

${formatTimeWithSeconds(
new Date(message.time),
this.hass.locale
Expand Down
1 change: 1 addition & 0 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,7 @@
"no_triggers": "No triggers",
"payload_display": "Payload display",
"recent_messages": "{n} most recently received message(s)",
"recent_tx_messages": "{n} most recently transmitted message(s)",
"show_as_yaml": "Show as YAML",
"triggers": "Triggers"
}
Expand Down