Skip to content

Display transmitted messages in MQTT debug info dialog#11531

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
emontnemery:mqtt_debug_info_tx
Feb 15, 2022
Merged

Display transmitted messages in MQTT debug info dialog#11531
bramkragten merged 3 commits intohome-assistant:devfrom
emontnemery:mqtt_debug_info_tx

Conversation

@emontnemery
Copy link
Copy Markdown
Collaborator

Proposed change

Display transmitted messages in MQTT debug info dialog

Depends on core PR home-assistant/core#65550

Screenshot:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@emontnemery
Copy link
Copy Markdown
Collaborator Author

The backend change is merged, this should be GTG

<li class="message">
<div class="time">
Received
${this.direction}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have kept it 1 element and add a direction property to it 😄

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

"no_triggers": "No triggers",
"payload_display": "Payload display",
"recent_messages": "{n} most recently received message(s)",
"recent_rx_messages": "{n} most recently received message(s)",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we lose all translations for this string

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that makes sense, I'll clean that up!

@bramkragten bramkragten enabled auto-merge (squash) February 15, 2022 11:12
@bramkragten bramkragten merged commit 26d4599 into home-assistant:dev Feb 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants