Fix dialog heading aria label #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsarnett
reviewed
Feb 3, 2022
zsarnett
previously approved these changes
Feb 3, 2022
Co-authored-by: Zack Barett <[email protected]>
zsarnett
approved these changes
Feb 3, 2022
bramkragten
added a commit
that referenced
this pull request
Feb 3, 2022
* Only upload wheels to PyPI (#11514) * Make sure we load data in update card (#11516) * Guard load diagnostics (#11518) * Design home - Fix GitHub Links (#11519) * Add filtering to system log card and error log card (#11166) Co-authored-by: Bram Kragten <[email protected]> * Handle unknown toggle state (#11522) * Fix dialog heading aria label (#11524) Co-authored-by: Zack Barett <[email protected]> * Use css to hide hint in quickbar (#11527) * Revert "Mobile click accessibility" (#11526) * Clear old src when disconnected so we can't fetch it with the wrong t… (#11528) * Add name of integration to diagnostics when more than 1 (#11523) * Bumped version to 20220203.0 Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Joakim Sørensen <[email protected]> Co-authored-by: Paulus Schoutsen <[email protected]> Co-authored-by: fpro1212 <[email protected]> Co-authored-by: Kuba Wolanin <[email protected]> Co-authored-by: Zack Barett <[email protected]>
|
You missed 5 files that don't use the
I normally suck at regex so I'm quite proud of that one 🪄 . |
I wish we could just set the heading as aria-label and not display it, if we would add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes the issue with dialog headers described here by @steverep : #10754 (comment)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: