Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Mobile click accessibility" #11526

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Revert "Mobile click accessibility" #11526

merged 2 commits into from
Feb 3, 2022

Conversation

bramkragten
Copy link
Member

Reverts #11447

This breaks dropdown on iOS, fixes #11520

@bramkragten bramkragten added this to the 2022.2.1 milestone Feb 3, 2022
@bramkragten bramkragten merged commit 5fde6e6 into dev Feb 3, 2022
@bramkragten bramkragten deleted the revert-11447-mobile-click-a11y branch February 3, 2022 15:33
@steverep
Copy link
Member

steverep commented Feb 3, 2022

Grrr... polymer stuff is so screwed up!

Instead of reverting it globally, you could just set it back to true just inside the paper-dropdown-menu components so it doesn't break everything again.

@bramkragten
Copy link
Member Author

Grrr... polymer stuff is so screwed up!

Instead of reverting it globally, you could just set it back to true just inside the paper-dropdown-menu components so it doesn't break everything again.

It is a global setting right? Can you set it to affect just 1 component?

@bramkragten
Copy link
Member Author

Anyway, we are migrating all paper dropdowns asap so we can enable it globally again

@steverep
Copy link
Member

steverep commented Feb 3, 2022

Yeah, I have been thinking about it the last couple hours and coming to the same conclusion. The only way it might work is by patching polymer directly. For example, create a copy of settings.js and gestures.js and tell paper-dropdown-menu to use the copy with cancelSyntheticClickEvents back to true in the copy.

I can try to do that, but if you are going to work on switching over to mwc-select right away then I won't waste my time and focus on the focus issues. FWIW, the mwc-select demos mostly work just fine with screen reader on mobile and desktop.

bramkragten added a commit that referenced this pull request Feb 3, 2022
@bramkragten @cdce8p
@ludeeus @balloob @fprokop @kubawolanin @zsarnett
20220203.0 (#11533)
51938fb 
* Only upload wheels to PyPI (#11514)

* Make sure we load data in update card (#11516)

* Guard load diagnostics (#11518)

* Design home - Fix GitHub Links (#11519)

* Add filtering to system log card and error log card (#11166)

Co-authored-by: Bram Kragten <[email protected]>

* Handle unknown toggle state (#11522)

* Fix dialog heading aria label (#11524)

Co-authored-by: Zack Barett <[email protected]>

* Use css to hide hint in quickbar (#11527)

* Revert "Mobile click accessibility" (#11526)

* Clear old src when disconnected so we can't fetch it with the wrong t… (#11528)

* Add name of integration to diagnostics when more than 1 (#11523)

* Bumped version to 20220203.0

Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Joakim Sørensen <[email protected]>
Co-authored-by: Paulus Schoutsen <[email protected]>
Co-authored-by: fpro1212 <[email protected]>
Co-authored-by: Kuba Wolanin <[email protected]>
Co-authored-by: Zack Barett <[email protected]>
@bramkragten
Copy link
Member Author

Let's focus on mwc-select then!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zsarnett zsarnett zsarnett approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
2022.2.1
Development

Successfully merging this pull request may close these issues.

Unable to pick Media source on iOS and iPadOS
4 participants
@bramkragten @steverep @zsarnett @homeassistant