Skip to content

Add mV unit to number and sensor entity documentation#1598

Merged
frenck merged 2 commits into
home-assistant:masterfrom
jbouwh:add-sensor-units-mV-mA
Dec 30, 2022
Merged

Add mV unit to number and sensor entity documentation#1598
frenck merged 2 commits into
home-assistant:masterfrom
jbouwh:add-sensor-units-mV-mA

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Dec 29, 2022

Proposed change

Add mV as a new unit for voltage.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

frenck
frenck previously approved these changes Dec 29, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@MartinHjelmare
Copy link
Copy Markdown
Member

Are we going to update the number integration too?

@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Dec 30, 2022

Are we going to update the number integration too?

Just added mV as a unit for the number integration and also updated the docs PR.

@jbouwh jbouwh requested a review from frenck December 30, 2022 11:21
@MartinHjelmare MartinHjelmare changed the title Add mV unit to sensor entity documentation Add mV unit to number and sensor entity documentation Dec 30, 2022
@frenck frenck merged commit 7c5ede6 into home-assistant:master Dec 30, 2022
@jbouwh jbouwh deleted the add-sensor-units-mV-mA branch December 30, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants