Add mV as a unit for voltage and enable conversions#84805
Merged
frenck merged 7 commits intoDec 30, 2022
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Also, please note that the way to "fix" this in 2023.1 beta is to remove the incorrect device class. |
epenet
previously requested changes
Dec 29, 2022
a41d610 to
97480f3
Compare
97480f3 to
f3c5ffe
Compare
This was referenced Dec 29, 2022
Merged
Contributor
Author
|
kvanzuijlen
pushed a commit
to kvanzuijlen/core
that referenced
this pull request
Dec 30, 2022
kvanzuijlen
pushed a commit
to kvanzuijlen/core
that referenced
this pull request
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The unit mV was added for device_class
voltage, but onlyVwas still accepted as valid unit.Further conversion support between V and mV (voltage) was missing.
Related frontend PR: home-assistant/frontend#14921
Type of change
Additional information
Add mV unit to number and sensor entity documentation developers.home-assistant#1598
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: