Add more device info for SmartThings devices

homeassistant/components/smartthings/__init__.py

@@ -452,9 +452,11 @@ def device_info(self) -> DeviceInfo:
         return DeviceInfo(
             configuration_url="https://account.smartthings.com",
             identifiers={(DOMAIN, self._device.device_id)},
-            manufacturer="Unavailable",
-            model=self._device.device_type_name,
+            manufacturer=self._device.status.ocf_manufacturer_name,
+            model=self._device.status.ocf_model_number,
             name=self._device.label,
+            hw_version=self._device.status.ocf_hardware_version,
+            sw_version=self._device.status.ocf_firmware_version,
         )
 
     @property

tests/components/smartthings/conftest.py

@@ -270,6 +270,12 @@ def _factory(label, capabilities, status: dict = None):
                 "deviceTypeName": "Switch",
                 "deviceNetworkType": "ZWAVE",
             },
+            "ocf": {
+                "manufacturerName": "Generic manufacturer",
+                "modelNumber": "123",
+                "hwVersion": "v4.56",
+                "firmwareVersion": "v7.89",
+            },
             "type": "DTH",
         }
         device = DeviceEntity(api, data=device_data)

tests/components/smartthings/test_binary_sensor.py

@@ -66,7 +66,7 @@ async def test_entity_and_device_attributes(
     assert entry.configuration_url == "https://account.smartthings.com"
     assert entry.identifiers == {(DOMAIN, device.device_id)}
     assert entry.name == device.label
-    assert entry.model == device.device_type_name
+    assert entry.model == device.status.ocf_model_number
     assert entry.manufacturer == "Unavailable"