Skip to content

Add more device info for SmartThings devices#95723

Merged
balloob merged 8 commits into
home-assistant:devfrom
guix77:smartthings-device-info
Jul 6, 2023
Merged

Add more device info for SmartThings devices#95723
balloob merged 8 commits into
home-assistant:devfrom
guix77:smartthings-device-info

Conversation

@guix77
Copy link
Copy Markdown
Contributor

@guix77 guix77 commented Jul 2, 2023

Proposed change

The manufacturer, the model number, the hardware version and the firmware version can be added into HA for a SmartThings device, because this data is provided by the API and pysmartthings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 2, 2023

Hey there @andrewsayre, mind taking a look at this pull request as it has been labeled with an integration (smartthings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smartthings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smartthings Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the tests for it to be merged.

@home-assistant home-assistant Bot marked this pull request as draft July 3, 2023 01:48
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@guix77 guix77 marked this pull request as ready for review July 5, 2023 13:40
@home-assistant home-assistant Bot requested a review from balloob July 5, 2023 13:40
@guix77
Copy link
Copy Markdown
Contributor Author

guix77 commented Jul 5, 2023

Thanks @balloob, done!

@balloob balloob merged commit 23d5fb9 into home-assistant:dev Jul 6, 2023
joostlek pushed a commit to joostlek/core that referenced this pull request Jul 6, 2023
* Add more device info for SmartThings devices

* Fix binary_sensor test

* Fix binary sensor test, try 2

* Fix and add SmartsThings new device info tests
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
@andrewsayre
Copy link
Copy Markdown
Member

Ooof, this shouldn't have been accepted as is. These attributes (ocf_manufacturer_name and ocf_model_number) are only relevant for Samsung appliances. No other SmartThings devices populate these values and expose the information a different way. Because this replaced the existing mapping to ST's device_type_name most people will now find new devices added to HA won't have a value. I'll work on a PR that's more discerning to correct this in the coming days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants