Add more device info for SmartThings devices#95723
Conversation
|
Hey there @andrewsayre, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
left a comment
There was a problem hiding this comment.
Looks good. Please fix the tests for it to be merged.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Thanks @balloob, done! |
* Add more device info for SmartThings devices * Fix binary_sensor test * Fix binary sensor test, try 2 * Fix and add SmartsThings new device info tests
|
Ooof, this shouldn't have been accepted as is. These attributes ( |
Proposed change
The manufacturer, the model number, the hardware version and the firmware version can be added into HA for a SmartThings device, because this data is provided by the API and pysmartthings.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: