Skip to content

Speed up routing URLs#95721

Merged
balloob merged 1 commit into
devfrom
fast_url_dispatcher
Jul 3, 2023
Merged

Speed up routing URLs#95721
balloob merged 1 commit into
devfrom
fast_url_dispatcher

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 2, 2023

alternative to #95717

Proposed change

Each resource added to aiohttp slows it down a bit because it has to do a linear search to resolve resources every time a request is made. DynamicResource need to run a regex to reject or accept. By indexing them we can get the frontend to load faster since we don't have to hit a lot of regexes to find the route that will accept.

aiohttp does a linear search for resources under the hood. With the index, we try to lookup the url parts first and than fallback to the default behavior if we cannot find a candidate. All the resolving and acceptance is still done by aiohttp internals, this PR only changes the order in which we try the routers to pick the one that is most likely first.

aiohttp seems to have given up on the tree approach they started because of how large of a breaking change it would be so I have little confidence this will ever get solved upstream.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 2, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review July 2, 2023 17:22
@bdraco bdraco requested a review from a team as a code owner July 2, 2023 17:22
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 2, 2023

Clear cache, reload ha, resolver no longer anywhere near the top of the profile.

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

@balloob balloob merged commit 2b66480 into dev Jul 3, 2023
@balloob balloob deleted the fast_url_dispatcher branch July 3, 2023 03:00
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 3, 2023

Thanks

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants