Speed up routing URLs#95721
Merged
Merged
Conversation
alternative to #95717
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
20 tasks
Member
Author
|
Clear cache, reload ha, resolver no longer anywhere near the top of the profile. |
Member
Author
|
Thanks |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #95717
Proposed change
Each resource added to aiohttp slows it down a bit because it has to do a linear search to resolve resources every time a request is made.
DynamicResourceneed to run a regex to reject or accept. By indexing them we can get the frontend to load faster since we don't have to hit a lot of regexes to find the route that will accept.aiohttp does a linear search for resources under the hood. With the index, we try to lookup the url parts first and than fallback to the default behavior if we cannot find a candidate. All the resolving and acceptance is still done by aiohttp internals, this PR only changes the order in which we try the routers to pick the one that is most likely first.
aiohttp seems to have given up on the tree approach they started because of how large of a breaking change it would be so I have little confidence this will ever get solved upstream.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: