Re-sort aiohttp resources at startup by least cost#95717
Closed
bdraco wants to merge 1 commit into
Closed
Conversation
aiohttp does a linear search for resources under the hood. We can move the cheap ones to the front since we have to make it through them all to find the ones we want
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Member
Author
|
I think #95721 is a better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment. I've been running this for a few months while looking for a better solution which has not appeared so I'm opening a PR in case someone has an idea... EDIT: opening the PR provided some inspiration and #95721 is an alternate solution
A "better" solution will likely have more complexity so as this does solve the problem in the short term (it will be more of a problem in the future as we add more resources to aiohttp) with low complexity this might be the best path forward.
aiohttp seems to have given up on the tree approach they started because of how large of a breaking change it would be so I have little confidence this will ever get solved upstream.
Proposed change
Each resource added to aiohttp slows it down a bit because it has to do a linear search to resolve resources every time a request is made.
DynamicResourceneed to run a regex to reject or accept. By moving them further in the list we can get the frontend to load faster since we don't have to hit a lot of regexes to find the route that will accept.aiohttp does a linear search for resources under the hood. We can move the cheap ones to the front since we have to make it through them all to find the ones we want.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: