Skip to content

Support launching app deep links in apple_tv integration#94705

Merged
bdraco merged 1 commit into
home-assistant:devfrom
michalmo:appletv-launch-url
Jun 16, 2023
Merged

Support launching app deep links in apple_tv integration#94705
bdraco merged 1 commit into
home-assistant:devfrom
michalmo:appletv-launch-url

Conversation

@michalmo
Copy link
Copy Markdown
Contributor

@michalmo michalmo commented Jun 16, 2023

Proposed change

Pyatv 0.12.1 added support for deep links (dependency updated in #94683). This PR adds support for launching deep links using the url media type, consistently with the androidtv_remote integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jun 16, 2023

@michalmo Since you have been making significant contributions here, you should add yourself to codeowners for this integration

https://github.com/home-assistant/architecture/blob/master/adr/0008-code-owners.md

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, confirmed working 👍

@bdraco bdraco merged commit 3778e1c into home-assistant:dev Jun 16, 2023
@michalmo
Copy link
Copy Markdown
Contributor Author

@michalmo Since you have been making significant contributions here, you should add yourself to codeowners for this integration

https://github.com/home-assistant/architecture/blob/master/adr/0008-code-owners.md

OK @bdraco, I added myself in my other open PR (#94704).

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: apple_tv new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants