Skip to content

Bump pyatv to 0.13.0#94683

Merged
bdraco merged 1 commit into
home-assistant:devfrom
michalmo:appletv-bump-pyatv
Jun 15, 2023
Merged

Bump pyatv to 0.13.0#94683
bdraco merged 1 commit into
home-assistant:devfrom
michalmo:appletv-bump-pyatv

Conversation

@michalmo
Copy link
Copy Markdown
Contributor

@michalmo michalmo commented Jun 15, 2023

Proposed change

The PR updates the pyatv dependency. This version includes improvements to volume handling and should address issues such as #76117. However, since the apple_tv integration will always say it supports volume (since the availability can change at any time), it's still possible that users might expect volume to work differently than it does. Therefore, I've added a documentation PR too, to help address this.

changelog: postlund/pyatv@v0.12.0...v0.13.0
notes: https://github.com/postlund/pyatv/releases/tag/v0.13.0

This dependency update also enables some new features which will come in other PRs later.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: apple_tv small-pr PRs with less than 30 lines. Quality Scale: No score labels Jun 15, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@postlund
Copy link
Copy Markdown
Contributor

Proper release notes here:
https://github.com/postlund/pyatv/releases/tag/v0.13.0
Had all kinds of problems with this one...

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jun 15, 2023

tested 👍

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jun 15, 2023

thanks @postlund @michalmo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: apple_tv Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service call to turn up or down volume on Homepod not executed

3 participants