Add missing fstrings in Local Calendar#92288
Merged
Merged
Conversation
Contributor
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
allenporter
approved these changes
Apr 30, 2023
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Good catch, thank you.
Deleting and recreating a new event may be a good idea
No, we need to preserve existing identifiers, or we may be partially editing without all event fields being passed on the request. Let's fix the underlying issue.
frenck
pushed a commit
that referenced
this pull request
Apr 30, 2023
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Apr 30, 2023
* dev: (581 commits) Only store and pass around coordinator in Rituals Perfume Genie (home-assistant#92298) Avoid returning statistics columns that the metadata knows are impossible (home-assistant#92095) Add `date` platform (home-assistant#81948) Prevent pysnmp from being installed as it does not work with newer python (home-assistant#92292) Use SnapshotAssertion in Renault tests (home-assistant#90778) Home Connect add WasherDryer support (home-assistant#90673) Move lastfm constants to separate file (home-assistant#92289) Fix august lock state when API reports locking and locked with the same timestamp (home-assistant#92276) Ensure onvif webhook can be registered (home-assistant#92295) Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 (home-assistant#92293) Bump pynina to 0.3.0 (home-assistant#92286) Fix mqtt not available when starting snips (home-assistant#92296) Extract Rituals Perfume Genie DataUpdateCoordinator into module (home-assistant#92284) Bump bleak to 0.20.2 (home-assistant#92294) Add missing fstrings in Local Calendar (home-assistant#92288) Remove myself from switcher_kis codeowners (home-assistant#92277) Handle AttributeError from wrong port in ONVIF config flow (home-assistant#92272) Auto repair incorrect collation on MySQL schema (home-assistant#92270) Update orjson to 3.8.11 (home-assistant#92228) Update coverage to 7.2.4 (home-assistant#92229) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
I noticed this when trying to figure out why I could not update a mid-sequence event to a different day. The integration can't seem to handle this even though the UI says it is possible.
Deleting and recreating a new event may be a good idea.This PR just makes sure the user has some actual information to go by as to why it does not work.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: