Add object source logger to profiler#90650
Merged
Merged
Conversation
bdraco
commented
Apr 1, 2023
8 tasks
balloob
approved these changes
Apr 3, 2023
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Add object source logger to profiler * fixes * cleanup * tweaks * logging * logging * too intensive * adjust * Update homeassistant/bootstrap.py * fixes * fixes * coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tagged this for beta since the risk is low given the only change affects debugging tools (profiler) and I didn't want to go another month without finding this leak.
Proposed change
To find the source of #89885 since its leaking
dictobjects, and its not realistic to expect a user to find the leak by comparing a list of 80000dicts manually.profiler.start_log_object_sourcesandprofiler.stop_log_object_sourcesprovide additional services for hunting memory leaks. These services do more intensive attempts to locate the source of a leak. This new service is designed to find fast leaks of common objects likedict. These services are useful for cases where the less intensiveprofiler.start_log_objectcannot provide useful information when there are 10000+ objects of the same type in memory with the same name as the object that is being leaked.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: