Allow loading UniFi entities on config options change#88762
Merged
frenck merged 3 commits intoMar 6, 2023
Conversation
8bc3327 to
beb4fe1
Compare
beb4fe1 to
6036472
Compare
starkillerOG
approved these changes
Mar 3, 2023
Contributor
starkillerOG
left a comment
There was a problem hiding this comment.
Looks good to me :)
Took me a while to figure out how it works ;)
Member
Author
Thanks! Well yes, lots of mechanisms going on :) |
frenck
requested changes
Mar 6, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Mar 6, 2023
Member
Author
|
Thank you @frenck 🎉 |
jpbaltazar
pushed a commit
to jpbaltazar/inels-home-assistant
that referenced
this pull request
Mar 8, 2023
…#88762) Co-authored-by: Franck Nijhof <frenck@frenck.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Builds on #88571
Unblocks #84942
During the refactoring of UniFi I didn't take care of how to trigger loading of entities based on changed config options. This PR brings this functionality back.
PR consists of two parts
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: