Only do unit conversion of met elevation when set in config entry

[chrisx8]

Proposed change

Move the conversion of elevation from feet to meters, so that it only happens when the elevation is stored in the config entry.

If the elevation is not set in the config entry, elevation is sourced from hass.config.elevation, which is always in meters

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: None
• This PR is related to issue: Display unit of elevation in met config flow #88283, Met integration does not describe Units of Elevation (ft, m, etc) #84895
• Link to documentation pull request: None

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of met can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign met Removes the current integration label and assignees on the issue, add the integration domain after the command.

[chrisx8]

As mentioned in #88283 (comment), this PR is step 1 of addressing the elevation unit issue in met.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[chrisx8]

Implemented the suggestion in review above.

Just to clarify, we want to apply the same unit conversion logic (and assume user entered elevation in feet) if:

• config_entry exists (CONF_TRACK_HOME is False or unset, not added as part of onboarding), AND
• Current Unit System is US

Am I understanding this correctly? Sorry for the confusion here...

[emontnemery]

Implemented the suggestion in review above.

Just to clarify, we want to apply the same unit conversion logic (and assume user entered elevation in feet) if:

• config_entry exists (CONF_TRACK_HOME is False or unset, not added as part of onboarding), AND
• Current Unit System is US

Am I understanding this correctly? Sorry for the confusion here...

Yeah, that's my suggestion, it fixes the bug where an elevation in meters in hass.config is incorrectly converted to meters.
The next step is to add an options flow so the user can correct their configuration once we drop unit conversion completely and ask US users with a manual configuration to update their configuration

[emontnemery]

Thanks, @chrisx8 👍