Display unit of elevation in met config flow

[chrisx8]

Breaking change

The met integration now requires elevation to be set in meters, regardless of the unit system set in Home Assistant. This mirrors the behavior of Home Assistant Core, which requires elevation to be in meters regardless of the unit system.

This only affects users who:

• set up the met integration manually via Settings (not set up automatically during onboarding), AND
• Home Assistant's unit system is not set to metric

Please double-check that elevation in met is set correctly, using the integration's "Configure" dialog.

Proposed change

Require elevation in met to be in meters.

Display the unit of elevation (always meters) in met's config flow data entry dialog.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Met integration does not describe Units of Elevation (ft, m, etc) #84895
• This PR is related to issue: none
• Link to documentation pull request: none

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of met can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign met Removes the current integration label and assignees on the issue, add the integration domain after the command.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[emontnemery]

LGTM based on the explanation from @chrisx8 👍

[frenck]

@emontnemery Sorry it isn't, it removes a conversion, thus breaking existing installations.

[frenck]

Left a comment above, this PR needs changes to prevent is being a breaking change for existing installations.

../Frenck

[emontnemery]

@chrisx8 it's quite the mess you've uncovered here.

I think we need to do this in steps, where one step is one PR:

1. Move the conversion of elevation from feet to meters so it only happens when the elevation is stored in the config entry: Only do unit conversion of met elevation when set in config entry  #88491
2. Add an option flow to allow users to reconfigure the location, including the elevation: Add options flow for met #88525
3. As a final step, implement the changes proposed in this PR together with a breaking change note asking users to double check the elevation: This PR

[chrisx8]

Rebased and added a breaking change note about requiring elevation to be in meters

[chrisx8]

@emontnemery Any update here?

This PR requires elevation in met to be in meters, and it will display the unit of elevation (always meters) in met's config flow data entry dialog. I have also added a breaking change note for the unit change.

[emontnemery]

Thanks a lot @chrisx8 for sorting out this mess 👍

A breaking change note has been added, and the impact of the change is now minimal because only manually setup config entries are affected