Skip to content

Fix indent on slow_range_in_select for MySQL/MariaDB#87581

Merged
balloob merged 1 commit into
home-assistant:devfrom
bdraco:slow_range_in_select
Feb 7, 2023
Merged

Fix indent on slow_range_in_select for MySQL/MariaDB#87581
balloob merged 1 commit into
home-assistant:devfrom
bdraco:slow_range_in_select

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 6, 2023

Proposed change

This is not a functional change since we would calculate this value and throw it away because it was only used on first_connection. By fixing the indent we save running a statement that will never get used and will avoid a future merge conflict.

This was added in #87409

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We would calculate this value and throw it away
because it was only used on first_connection
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 6, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@balloob balloob merged commit 3aa744e into home-assistant:dev Feb 7, 2023
balloob pushed a commit that referenced this pull request Feb 7, 2023
We would calculate this value and throw it away
because it was only used on first_connection
@balloob balloob mentioned this pull request Feb 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants