Skip to content

Browse media support in universal media player#85668

Merged
bieniu merged 2 commits into
home-assistant:devfrom
Drafteed:universal-browse-media
Feb 23, 2023
Merged

Browse media support in universal media player#85668
bieniu merged 2 commits into
home-assistant:devfrom
Drafteed:universal-browse-media

Conversation

@Drafteed
Copy link
Copy Markdown
Contributor

@Drafteed Drafteed commented Jan 11, 2023

Proposed change

This change allows forward browse media to active child in universal media player and allows it to be overridden in config.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@erkr
Copy link
Copy Markdown

erkr commented Feb 8, 2023

Any information which core version this will become available?! I'm really looking forward for this 🤓

@Drafteed Drafteed changed the title Allow forward and override browse media in universal media player Browse media support in universal media player Feb 10, 2023
Copy link
Copy Markdown
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice idea 👍

@bieniu bieniu added the smash Indicator this PR is close to finish for merging or closing label Feb 12, 2023
@bieniu bieniu merged commit 6474297 into home-assistant:dev Feb 23, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2023
@Drafteed Drafteed deleted the universal-browse-media branch February 25, 2023 01:12
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests integration: universal new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Universal media player can not browse media

4 participants