Skip to content

Pass assumed_state property in universal media player#87846

Merged
bieniu merged 1 commit into
home-assistant:devfrom
Drafteed:universal-assumed-state
Feb 25, 2023
Merged

Pass assumed_state property in universal media player#87846
bieniu merged 1 commit into
home-assistant:devfrom
Drafteed:universal-assumed-state

Conversation

@Drafteed
Copy link
Copy Markdown
Contributor

@Drafteed Drafteed commented Feb 10, 2023

Proposed change

This simple PR will add passing assumed_state property from child entity in universal media player.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bieniu bieniu added the smash Indicator this PR is close to finish for merging or closing label Feb 12, 2023
Copy link
Copy Markdown
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add

@bieniu bieniu merged commit f18c0bf into home-assistant:dev Feb 25, 2023
@Drafteed Drafteed deleted the universal-assumed-state branch February 25, 2023 06:46
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests integration: universal new-feature Quality Scale: internal small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants