Skip to content

Increase Netgear speedtest period to 2 hours#85299

Merged
frenck merged 1 commit into
home-assistant:devfrom
starkillerOG:netgear_speedtest
Jan 6, 2023
Merged

Increase Netgear speedtest period to 2 hours#85299
frenck merged 1 commit into
home-assistant:devfrom
starkillerOG:netgear_speedtest

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Jan 6, 2023

Breaking change

Proposed change

Increase Netgear speedtest period from 30 minutes to 2 hours to decrease data usage, see issue: #85137

When speedtest sensors are added for the first time and no last sensor data is available, do a speedtest emidiatly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 6, 2023

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netgear can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign netgear Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

@frenck frenck merged commit d9be9fe into home-assistant:dev Jan 6, 2023
if sensor_data is not None:
self._value = sensor_data.native_value
else:
self.schedule_update_ha_state()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entity state is always updated by default when the entity is added to Home Assistant. We don't need this line.

What was the goal with this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually in this case the update coordinator does not fetch new data from the API when the entity is added to prevent large bandwidth usage of speedtest during boot of homeassistant.

So the goal is to have the update coordinator fetch data from the API only if no previous values are available (so this is a new entity).

@MartinHjelmare did I use the wrong command?
I think so...
Schould I have used await self.coordinator.async_request_refresh()?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. 👍

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants