Fix dsmr_reader peak hour consumption unit of measurement#85301
Merged
frenck merged 2 commits intoJan 6, 2023
Merged
Conversation
Instead of using kWh, the unit of measurement should remain kW
Contributor
|
Hey there @depl0y, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I accidentally used kWh as unit of measurement for the quarter peak usage, while it should be kW. The value doesn't represent the energy consumed over time, but an average of how much is being consumed within a quarter. DSMR Reader and the telegram data in the energy meter also use kW as unit of measurement for this data, so it makes most sense to also use this here.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: