Skip to content

Add quarter-hour peak consumption sensors#84271

Merged
frenck merged 1 commit into
home-assistant:devfrom
Glodenox:feature/add-quarter-hour-peak-consumption
Dec 21, 2022
Merged

Add quarter-hour peak consumption sensors#84271
frenck merged 1 commit into
home-assistant:devfrom
Glodenox:feature/add-quarter-hour-peak-consumption

Conversation

@Glodenox
Copy link
Copy Markdown
Contributor

@Glodenox Glodenox commented Dec 19, 2022

Proposed change

Release 5.9.0 of DSMR Reader adds the option to expose the quarter-hour peak electricity consumption information via MQTT. This PR adds these 3 values as new sensors.

Just for some context: next year, the cost of electricity in Belgium will be partially influenced by the peak consumption. An average of the consumption is taken for each block of 15 minutes and the highest average of each month is used to calculate part of the invoice. The idea is to encourage people to spread out their electricity consumption. It's not a big factor though, so the impact on the invoice is still quite limited. There is almost certainly going to be another update to DSMR Reader in the coming months, as the data has very recently become available within the meter's datagrams. Right now, DSMR Reader still does the calculation by itself.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @depl0y, mind taking a look at this pull request as it has been labeled with an integration (dsmr_reader) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dsmr_reader can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign dsmr_reader Removes the current integration label and assignees on the issue, add the integration domain after the command.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 20, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Glodenox 👍

Happy Holidays! 🎄

../Frenck

@frenck frenck merged commit cb3ab9b into home-assistant:dev Dec 21, 2022
@Glodenox Glodenox deleted the feature/add-quarter-hour-peak-consumption branch December 21, 2022 09:18
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed integration: dsmr_reader new-feature Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DSMR_Reader: not creating sensors for mqtt topic 'dsmr/consumption/quarter-hour-peak-electricity'

2 participants