Skip to content

Bump bluetooth-data-tools to 0.3.1 for ld2410-ble#85278

Merged
balloob merged 1 commit into
home-assistant:devfrom
cgarwood:ld2410_ble_dep_fix
Jan 6, 2023
Merged

Bump bluetooth-data-tools to 0.3.1 for ld2410-ble#85278
balloob merged 1 commit into
home-assistant:devfrom
cgarwood:ld2410_ble_dep_fix

Conversation

@cgarwood
Copy link
Copy Markdown
Member

@cgarwood cgarwood commented Jan 6, 2023

Proposed change

CI is failing the gen_requirements_all check because ld2410_ble has bluetooth-data-tools==0.3.0 while the other integrations were bumped to bluetooth-data-tools==0.3.1.

This PR bumps bluetooth-data-tools==0.3.1 for ld2410_ble.

Guessing it's from this PR that was merged a couple hours ago: #83883

I don't have bluetooth setup on my test box, so I can't test.

cc @bdraco @930913

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed dependency-bump Pull requests that update a dependency file integration: ld2410_ble small-pr PRs with less than 30 lines. Quality Scale: No score labels Jan 6, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 6, 2023

Hey there @930913, mind taking a look at this pull request as it has been labeled with an integration (ld2410_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ld2410_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ld2410_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cgarwood

@balloob balloob merged commit 9e68117 into home-assistant:dev Jan 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 7, 2023
@cgarwood cgarwood deleted the ld2410_ble_dep_fix branch November 21, 2024 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed dependency-bump Pull requests that update a dependency file integration: ld2410_ble Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants